Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: chrysle <fritzihab@posteo.de>
  • Loading branch information
3 people committed Feb 5, 2024
1 parent 80b7f21 commit 0a6d976
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ markdown-friendly table.
To see the status since the last time the scenarios were run open [table.md](table.md)[^1].

Please note:
* Mixing package types within a single namespace is not supported. While it may work in some cases, it may also break depending on the software versions used, the install commands issued, or the order of commands. It is generally advisable to not mix types.
* Mixing package types within a single namespace is not supported. While it may work in some cases, it may also break depending on the software versions used, the install commands issued, or the order of commands. It is generally advisable not to mix types.
* The `pkg_resources` method of namspacing is [deprecated](https://setuptools.pypa.io/en/latest/pkg_resources.html).
Whenever possible, developers are encouraged to migrate away from it.
* [PEP 420](https://www.python.org/dev/peps/pep-0420/) was accepted as part of Python 3.3. For wider compatibility (going back to Python 2.3), use the `pkgutil` method.
* Zipped eggs don't play nicely with namespace packaging, and may be implicitly installed by commands like `python setup.py install`. To prevent this, it is recommended that you set [`zip_safe=False`](http://setuptools.readthedocs.io/en/latest/setuptools.html#setting-the-zip-safe-flag) in `setup.py`, as we do here. Please also note that distributing packages via egg files is also considered deprecated.
* Zipped eggs don't play nicely with namespace packaging, and may be implicitly installed by commands like `python setup.py install`. To prevent this, it is recommended that you set [`zip_safe=False`](http://setuptools.readthedocs.io/en/latest/setuptools.html#setting-the-zip-safe-flag) in `setup.py`, as we do here. Please also note that distributing packages via egg files is considered deprecated.
* The tests reported in [table.md](table.md) use `pip` with *build isolation* and build-backend APIs.
This is triggered by the presence of a `pyproject.toml` file in each package source directory.
If your package does not have a `pyproject.toml` file,
Expand All @@ -57,4 +57,4 @@ specific use cases they are interested in supporting.


[^1]: If you would like to know about deprecated installation methods (e.g. via
`python setup.py install`) or Python 2.7, please have a look on [legacy_table.md](legacy_table.md).
`python setup.py install`) or Python 2.7, please have a look at [legacy_table.md](legacy_table.md).
3 changes: 2 additions & 1 deletion report_to_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
session_name = session['name']
session_detailled_name = session['signatures'][-1]
session_interpreter = session_detailled_name.replace(session_name + "-", "python")
session_name = session_name.replace("session_", "")
# TODO: Replace with `str.removeprefix()` in Python 3.12
session_name = session_name[len("session_") :]

f.write('| {} | {} | {} | {} | {} |\n'.format(
session_name,
Expand Down

0 comments on commit 0a6d976

Please sign in to comment.