Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should warn about relative URLs in links and images #71

Open
theacodes opened this issue Mar 27, 2018 · 1 comment
Open

Should warn about relative URLs in links and images #71

theacodes opened this issue Mar 27, 2018 · 1 comment
Assignees
@theacodes
Labels
enhancement help wanted

Comments

@theacodes
Copy link
Member

Such relative URLs will not work correctly when displayed on PyPI.
@theacodes theacodes self-assigned this Apr 10, 2018
@theacodes
Copy link
Member Author

Hrm, I have a few ways I can do this. I can either check for these links using a couple of regexes (ew) before passing to clean, or I can see if it's possible to use bleach/bleach.linkify to collect these. I'd need to extend clean to report warnings as well.

LexiconCode pushed a commit to dictation-toolbox/Caster that referenced this issue Mar 30, 2019
Converted to absolute URLs
9f500cc 
Relative URLs are fine for Github but break on pypi. pypa/readme_renderer#71
@miketheman miketheman mentioned this issue May 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theacodes theacodes

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theacodes