-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple test failures with v41 #302
Comments
We use Here's what it looks like on macOS running 3.10 for the 41.0 release: $ git checkout 41.0
HEAD is now at 9c0f7d8 Release 41.0 (#292)
$ tox -e py310
py310: install_deps> python -I -m pip install pytest pytest-cov
.pkg: install_requires> python -I -m pip install 'setuptools>=40.8.0'
.pkg: _optional_hooks> python /usr/local/Cellar/tox/4.13.0/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: get_requires_for_build_sdist> python /usr/local/Cellar/tox/4.13.0/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: get_requires_for_build_wheel> python /usr/local/Cellar/tox/4.13.0/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: install_requires_for_build_wheel> python -I -m pip install wheel
.pkg: prepare_metadata_for_build_wheel> python /usr/local/Cellar/tox/4.13.0/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: build_sdist> python /usr/local/Cellar/tox/4.13.0/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
py310: install_package_deps> python -I -m pip install 'Pygments>=2.5.1' 'bleach>=2.1.0' 'cmarkgfm>=0.8.0' 'docutils>=0.13.1'
py310: install_package> python -I -m pip install --force-reinstall --no-deps /Users/miketheman/workspace/miketheman/readme_renderer/.tox/.tmp/package/1/readme_renderer-41.0.tar.gz
py310: commands[0]> pytest --strict-markers --cov
======================================================================================= test session starts =======================================================================================
platform darwin -- Python 3.10.13, pytest-8.0.2, pluggy-1.4.0
cachedir: .tox/py310/.pytest_cache
rootdir: /Users/miketheman/workspace/miketheman/readme_renderer
plugins: cov-4.1.0
collected 91 items
tests/test_clean.py . [ 1%]
tests/test_cli.py ............... [ 17%]
tests/test_markdown.py ............................................ [ 65%]
tests/test_noextra.py ss [ 68%]
tests/test_rst.py ............................ [ 98%]
tests/test_txt.py . [100%]
--------- coverage: platform darwin, python 3.10.13-final-0 ----------
Name Stmts Miss Branch BrPart Cover
---------------------------------------------------------------
readme_renderer/__init__.py 0 0 0 0 100%
readme_renderer/__main__.py 44 7 22 4 77%
readme_renderer/clean.py 39 3 20 1 93%
readme_renderer/markdown.py 46 6 8 2 85%
readme_renderer/rst.py 34 0 12 1 98%
readme_renderer/txt.py 6 0 0 0 100%
tests/__init__.py 0 0 0 0 100%
tests/test_clean.py 3 0 0 0 100%
tests/test_cli.py 46 0 22 0 100%
tests/test_markdown.py 12 0 6 0 100%
tests/test_noextra.py 9 4 2 0 45%
tests/test_rst.py 39 0 8 0 100%
tests/test_txt.py 11 0 6 0 100%
---------------------------------------------------------------
TOTAL 289 20 106 8 91%
================================================================================== 89 passed, 2 skipped in 2.09s ==================================================================================
.pkg: _exit> python /usr/local/Cellar/tox/4.13.0/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
py310: OK (23.28=setup[20.46]+cmd[2.83] seconds)
congratulations :) (23.42 seconds) Mainly, note the difference in the Considering that |
Thanks for following up. I removed all plugins except pytest-cov and made sure to update pytest-cov and pluggy to match what your tox is installing. I even updated my python to the latest upstream. I also installed the optional dep cmarkgfm to make sure all tests were being excersised. tests output w/out plugins
This is in the context of Fink, a package manager. I can't use the compiled nh3 wheels because policy is to not use vendor binaries (MacPorts also has the same policy, don't know about homebrew). We also avoid testing with tox because it has network access during the build to download many deps (most of which already exist in the build system), which is also against policy (as with many other Linux distributions). So that's why I'm running the tests directly rather than through a test runner. |
This actually led me to make a minimal install with no other python mods installed. I then ran |
This looks similar to what I was seeing when I reported #310, and resolved in #315. @nieder The test suite compares rendered documents against known outputs, and different docutils versions sometimes change their output. This has the potential to be brittle, but is why it's so important to rely on tox to set up the test environment. @miketheman I anticipate that this can be closed. |
@kurtmckee it does look similar. Trying to update local docutils (to not the latest but newer than I have) fixes a bunch of the test failures, so it does seem to be docutils fragility. |
This is macOS with python3.10. Unfortunately, it's for readme-renderer-v41 because I can't update to 42 which needs nh3, which needs rust, which I don't have.
Test results
The text was updated successfully, but these errors were encountered: