typing: allow PathLike objects in addition to strs #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some projects use pathlib or other libraries to encapsulate file system paths instead of working with strs (or bytes) directly. These classes implement the os.PathLike interface which the functions in `os.path` support in addition to strs. This changes all functions that accept paths to accept PathLike objects in addition to strings. The way the backend_path attribute is set in `BuildBackendHookCaller.__init__()` was also modified so the typing was correct.
gotmax23
force-pushed
the
path-typing
branch
from
25ae655
to
1d04b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects use pathlib or other libraries to encapsulate file system paths instead of working with strs (or bytes) directly. These classes implement the os.PathLike interface which the functions in
os.pathsupport in addition to strs.This changes all functions that accept paths to accept PathLike objects in addition to strings. The way the backend_path attribute is set in
BuildBackendHookCaller.__init__()was also modified so the typing was correct.Follow-up-to: #167