Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the detection logic for MSYS2 #908

Merged
merged 6 commits into from
Feb 2, 2023
Merged

Improve the detection logic for MSYS2 #908

merged 6 commits into from
Feb 2, 2023

Conversation

dukecat0
Copy link
Member

@dukecat0 dukecat0 commented Oct 30, 2022 •
edited
Loading

  • I have added an entry to docs/changelog.md

Summary of changes

Improve the detection logic for MSYS2 to avoid entering an infinite loop.

Closes #701

Test plan

Tested by running

pipx install black --verbose

@dukecat0 dukecat0 mentioned this pull request Oct 30, 2022
Closed
1 task
@dukecat0 dukecat0 merged commit be2531a into pypa:main Feb 2, 2023
@dukecat0 dukecat0 deleted the MSYS branch February 2, 2023 06:55
@chdka
Copy link
Contributor

chdka commented Feb 10, 2023

When using other platforms in MSYS2 e.g. UCRT64 the problem of the endless loop still exists.

sysconfig.get_platform()

returns mingw_x86_64_ucrt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pipx enters in infinite loop when trying to install a package on python distributed with MSYS2 on Windows
3 participants
@dukecat0 @chdka @uranusjr