-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update *Edit this page* link #761
Conversation
Closes #760 |
ba1004d
to
9f9271b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts need to be resolved.
* Fix python 3.6-3.8 compatability error All PR CI checks are currently failing because a method call was added to the `pipx.commands.reinstall.reinstall` function which was only added in python 3.9 Replaced that method call with a python >=3.6 workaround * fixed formatting to black's satisfaction Co-authored-by: Alex Tremblay <alex@tremblay.in>
23af4bc
to
a5a3c91
Compare
@gaborbernat I've resolved the merge conflicts. This can be added to the
|
# use PurePath.relative_to in a try block instead | ||
# of PurePath.is_relative_to, for python 3.6-3.8 compatability | ||
Path(python).relative_to(venv_dir) | ||
python_relative_to_venv_dir = True | ||
except ValueError: | ||
pass | ||
else: | ||
python_relative_to_venv_dir = False | ||
|
||
if python_relative_to_venv_dir: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems unrelated, what happened here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the PR to avoid merging this. Please open a new PR and keep the change set scopped to the PR description.
This reverts commit 9d24fb9.
docs/changelog.md
Summary of changes
mkdocs.yml
to includeReference: MkDocs User guide configuration page
Test plan
Tested by running the following in a python virtual environment:
The updated docs can be viewed at http://127.0.0.1:8000/. Click on the pencil icon towards the top right part of the page and confirm that the link redirects to [this page].(https://github.com/pypa/pipx/edit/main/docs/index.md)