Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new env variable to allow spaces in home path #1446

Merged
merged 12 commits into from
Jun 23, 2024

Conversation

Gitznik
Copy link
Contributor

@Gitznik Gitznik commented Jun 10, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Introduces an environment variable to silence the warning for having a space in the pipx home path.

Improves the docs on how to troubleshoot the warning and move the pipx installation location in general. This makes the discussion I created a while ago redundant.

Resolves #1320

Test plan

Tested by running

nox -s tests-3.8 -- -k test_environment

@Gitznik
Copy link
Contributor Author

Gitznik commented Jun 10, 2024

@huxuan if you have the time, could you please verify that the windows example for moving the pipx install location actually works? Or maybe even translate it to powershell?

@Gitznik Gitznik marked this pull request as draft June 10, 2024 16:06
@Gitznik Gitznik marked this pull request as ready for review June 10, 2024 17:14
@huxuan
Copy link
Member

huxuan commented Jun 11, 2024

@huxuan if you have the time, could you please verify that the windows example for moving the pipx install location actually works? Or maybe even translate it to powershell?

Gotcha, will take a look later.

docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
@huxuan
Copy link
Member

huxuan commented Jun 16, 2024

Could you please verify that the windows example for moving the pipx install location actually works? Or maybe even translate it to powershell?

Verified and translated! PTAL

@huxuan huxuan force-pushed the allow_spaces_in_home_via_envvar branch from 92e0f10 to d3fefee Compare June 17, 2024 18:17
huxuan
huxuan previously approved these changes Jun 17, 2024
@Gitznik
Copy link
Contributor Author

Gitznik commented Jun 17, 2024

Sorry had to add just one small change to make sure spaces in the paths are not a problem when using bash.

@huxuan
Copy link
Member

huxuan commented Jun 17, 2024

Sorry had to add just one small change to make sure spaces in the paths are not a problem when using bash.

looks like the double quotes are also needed for the dirs and $NEW_LOCATION in powershell to work with spaces in paths.

huxuan
huxuan previously approved these changes Jun 18, 2024
@huxuan huxuan force-pushed the allow_spaces_in_home_via_envvar branch from e33ee59 to 8d9ac27 Compare June 18, 2024 08:14
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Show resolved Hide resolved
docs/troubleshooting.md Show resolved Hide resolved
src/pipx/animate.py Outdated Show resolved Hide resolved
src/pipx/emojis.py Outdated Show resolved Hide resolved
docs/troubleshooting.md Outdated Show resolved Hide resolved
@Gitznik Gitznik force-pushed the allow_spaces_in_home_via_envvar branch from 018af10 to e8d1bf0 Compare June 22, 2024 11:48
@Gitznik Gitznik marked this pull request as draft June 22, 2024 11:48
@Gitznik Gitznik marked this pull request as ready for review June 22, 2024 13:19
@huxuan huxuan merged commit 6ba9c0b into pypa:main Jun 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve docs for resolving space in home path warning
3 participants