-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: make install-all gather errors in batch #1348
Conversation
Thanks for the quick submission; please add a changelog entry of type feature, as this is a fundamental change to the behaviour. |
Thanks for the response.
I have use the pull request number directly as the issue number, let me know if I need to create a new issue for this. |
2c8dac5
to
eb9994b
Compare
Co-authored-by: Jason Lam <meowmeowcat1211@gmail.com>
for more information, see https://pre-commit.ci
6ccb727
to
8a5c027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Co-authored-by: chrysle <fritzihab@posteo.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Ha, and I was actually mistaken with the "stylistic convention" – but doesn't matter I guess.
That is OK, we can follow up this in #1357. I will mark it as ready for review then. |
Thanks! |
changelog.d/
(if the patch affects the end users)Summary of changes
As discussed in #1132 (comment),
install-all
needs a more robust strategy to deal with failed packages, so almost the same logic asreinstall-all
is copied here. Besides, a test case forinstall-all
is added.Test plan
Tested by running
BTW, this pull request is a refactor, so no news is added and there is also no referenced issue. Let me know if it is necessary.