Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change --global parameter position on ensurepath command #1338

Closed

Conversation

marcosalberto
Copy link

…tation

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Change --global parameter position on ensurepath command

Test plan

Tested by running

➜  ~ sudo pipx ensurepath --global
Password:
usage: pipx [-h] [--quiet] [--verbose] [--global] [--version]
            {install,uninject,inject,upgrade,upgrade-all,uninstall,uninstall-all,reinstall,reinstall-all,list,interpreter,run,runpip,ensurepath,environment,completions} ...
pipx: error: unrecognized arguments: --global

➜  ~ sudo pipx --global ensurepath
/usr/local/bin is already in PATH.

⚠️  All pipx binary directories have been added to PATH. If you are sure you want to proceed, try again with the '--force' flag.

Otherwise pipx is ready to go! ✨ 🌟 ✨
➜  ~

Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for raising and fixing the problem 👍

@Gitznik Gitznik linked an issue Apr 10, 2024 that may be closed by this pull request
@chrysle
Copy link
Contributor

chrysle commented Apr 11, 2024

I believe we could also add the --global option to the shared parser, so that the original command works? This syntax is a bit unpractical.

@dukecat0
Copy link
Member

I believe we could also add the --global option to the shared parser, so that the original command works?

I am +1 on this.

@dukecat0 dukecat0 closed this May 11, 2024
@dukecat0
Copy link
Member

@marcosalberto Thanks for your contribution, but I think it's better to fix the problem from the source, instead of asking the user to change the order.

@marcosalberto
Copy link
Author

@dukecat0 for sure, my PR aimed to fix the documentation fast to turn the experience for new users easy.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global parameter does not work using ensurepath command
4 participants