add preinstall with multiple packages example, cli help and test #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is not quite obvious on first glance. Could you also tweak the CLI help? |
Gitznik
previously approved these changes
Apr 2, 2024
gempir
changed the title
|
I think a newsfragment ( |
|
I'm sorry, I don't know what a newsfragment is. Where do I find that? What do you want me to add |
Take a look at our contributing guide. |
chrysle
approved these changes
Apr 3, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added examples of how to install multiple packages with preinstall. I had to dig deep into the initial PR to find out how this is supposed to be done. https://github.com/pypa/pipx/pull/900/files#r1260526621
Test plan
Just read the docs.