-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert platformdirs on MacOS and Windows #1297
Conversation
By the way, should we have |
IMHO - if platformdirs isn't providing any value on Windows or Mac, it should probably be removed and pipx should fallback to a consistent behavior across platforms. |
The benefit is specifically on linux, adhering to the xdg spec. IMO that's a good reason to keep it. we need to keep the package anyways to be backwards compatible with anyone that used the default location since 1.2
I don't think I'm fond of automatically removing it, but maybe we can print a hint that it can safely be deleted by the user? |
As especially downstream packagers are really pleased if it is being followed (see e.g. Debian).
Let's do this at info level. |
…' into revert_platformdirs
changelog.d/
(if the patch affects the end users)Summary of changes
On MacOS and Windows, we now use the old paths again, while using the post 1.2.0 paths as fallback.
On Linux - nothing changed.
Resolves #1257
Test plan
Tested by running
Existing test suite