-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to note admonition in readme #1216
Conversation
Is that a problem? I always thought that's what a website is for. |
Github does have a syntax for admonitions, and it doesn't match anything else. I wonder if it could be supported via a plugin, though? |
And I'm pretty sure the reason it's currently broken is due to the square bracket part being on the same line. If you added an extra empty line (which IIRC is allowed), then formatters will keep it as is instead of squishing them together. But that doesn't solve showing this in the docs. So far I've just used conditional blocks to get both, but something more elegant would be nice. |
Ahh, found it in the third-party extensions page for Python-Markdown: https://github.com/dahlia/markdown-gfm-admonition (From https://github.com/Python-Markdown/markdown/wiki/Third-Party-Extensions#additional-tags) |
@henryiii Thanks a lot for fixing this! |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
a08aca0
to
1f81055
Compare
Great find @henryiii , thanks for taking this over 👌 |
changelog.d/
(if the patch affects the end users)Summary of changes
The current syntax does not render correctly and is not in line with the rest of the docs. I could not find any more usages of the other syntax in the docs.
See #1215 for the source of this PR.
Test plan
Tested by running
nox -s build_docs
and checkingsite/index.html