-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use modern PEP 723 syntax, fix mistake in name #1180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
dukecat0
previously approved these changes
Jan 4, 2024
Please add a changelog entry. |
@henryiii would it be possible to make the tracebacks friendlier? Currently they show Traceback (most recent call last):
File "<string>", line 11, in <module>
ModuleNotFoundError: No module named 'requests' Would be nice if that read |
I can look into that. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
1 task
dukecat0
approved these changes
Jan 5, 2024
henryiii
changed the title
fix: use modern PEP 723 syntax
fix: use modern PEP 723 syntax, fix mistake in name
Jan 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.md
Summary of changes
PEP 723 has been updated to use a
scripts
block and norun
section. This updates to the new syntax,but still runs with the old syntax, producing a warning.This can be upgraded to an error (but with a nice message) later (or now, if you prefer, as it's still undocumented).Edit: the old form used the wrong name (requirements instead of dependencies) so I went ahead and made it an error now. I can still do the soft deprecation instead though if that’s preferred.
Test plan
Tested by running
There were 18 failures before this PR, and 18 after, so hoped that was good! :)