Fix pipenv shell --quiet to actually suppress output #6500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5954
The
--quietflag andPIPENV_QUIETenvironment variable now properly suppress all shell activation output.Problem
When running
pipenv shell, users see 3 lines of output:The
--quietflag was documented but didn't fully suppress the output - specifically, it didn't suppress the activation command echo in pexpect-based compat mode.Solution
Pass
quietparameter tofork_compat(): The shell's compat mode now receives the quiet setting.Use
setecho(False)in quiet mode: When quiet mode is enabled, the pexpect session disables echo before sending the activation command, then re-enables it after. This prevents the activation command from being displayed.Respect
PIPENV_QUIETenvironment variable: The shell command now checksproject.s.is_quiet()in addition to the--quietflag, so users can setPIPENV_QUIET=1globally.Usage
Changes
pipenv/shells.py: Addedquietparameter tofork_compat(), usessetecho(False)to suppress activation command outputpipenv/routines/shell.py: Passquiettofork_compat(), also respectPIPENV_QUIETenvironment variable viaproject.s.is_quiet()Pull Request opened by Augment Code with guidance from the PR author