Solve case when the the version is not in the MAX_VERSIONS #6380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the KeyError encountered when a package’s version specifier contains a major version that is not present in MAX_VERSIONS.
- Added an integration test for installing a package with an invalid Python version specifier (typedb-driver 3.0.5).
- Modified the version comparison logic in pipenv/utils/markers.py to handle cases where the major version is not listed in MAX_VERSIONS.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/test_install_markers.py | Added a new integration test for handling an invalid Python version specifier. |
| pipenv/utils/markers.py | Updated version comparison logic in _format_pyspec and fix_version_tuple functions. |
Files not reviewed (1)
- news/6380.bugfix.rst: Language not supported
Comments suppressed due to low confidence (1)
pipenv/utils/markers.py:127
- [nitpick] The composite condition checking for 'next_tuple[0] not in MAX_VERSIONS or not next_tuple[1] <= MAX_VERSIONS[next_tuple[0]]' is complex; consider refactoring it into descriptive boolean variables to improve readability.
if (
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
oz123
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Fixes #6370
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.