Skip to content

Fixes for ruff rule PLW1508 #6367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Fixes for ruff rule PLW1508 #6367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pipenv/environments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,15 +425,15 @@ def is_using_venv() -> bool:
return result


def is_in_virtualenv():
def is_in_virtualenv() -> bool:
"""
Check virtualenv membership dynamically

:return: True or false depending on whether we are in a regular virtualenv or not
:return: True or False depending on whether we are in a regular virtualenv or not
:rtype: bool
"""

pipenv_active = os.environ.get("PIPENV_ACTIVE", False)
pipenv_active = os.environ.get("PIPENV_ACTIVE")
virtual_env = bool(os.environ.get("VIRTUAL_ENV"))
ignore_virtualenvs = bool(get_from_env("IGNORE_VIRTUALENVS"))
return virtual_env and not (pipenv_active or ignore_virtualenvs)
Expand Down
7 changes: 2 additions & 5 deletions pipenv/utils/pip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,5 @@ def get_pip_args(
return list(dict.fromkeys(arg_set))


def get_trusted_hosts():
try:
return os.environ.get("PIP_TRUSTED_HOSTS", []).split(" ")
except AttributeError:
return []
def get_trusted_hosts() -> List[str]:
return os.environ.get("PIP_TRUSTED_HOSTS", "").split()