Skip to content

Drop py3.8 #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Drop py3.8 #6351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33f8e75
chore: drop python3.8
oz123 Jan 22, 2025
c7d6df4
ci: update pre-commit hook pyproject-fmt
oz123 Jan 22, 2025
9aac5e3
chore: fix ruff linting
oz123 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.8, 3.9, "3.10", 3.11, 3.12, 3.13]
python-version: [3.9, "3.10", 3.11, 3.12, 3.13]
os: [MacOS, Ubuntu, Windows]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ repos:
stages: [manual]

- repo: https://github.com/tox-dev/pyproject-fmt
rev: "2.2.4"
rev: "2.4.3"
hooks:
- id: pyproject-fmt

Expand Down
8 changes: 5 additions & 3 deletions pipenv/utils/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,11 @@ def constraints(self):
def get_resolver(self, clear=False):
from pipenv.patched.pip._internal.utils.temp_dir import TempDirectory

with global_tempdir_manager(), get_build_tracker() as build_tracker, TempDirectory(
globally_managed=True
) as directory:
with (
global_tempdir_manager(),
get_build_tracker() as build_tracker,
TempDirectory(globally_managed=True) as directory,
):
pip_options = self.pip_options
finder = self.finder()
wheel_cache = WheelCache(pip_options.cache_dir)
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ license = { text = "MIT License (MIT)" }
authors = [
{ name = "Pipenv maintainer team", email = "distutils-sig@python.org" },
]
requires-python = ">=3.8"
requires-python = ">=3.9"
classifiers = [
"License :: OSI Approved :: MIT License",
"Programming Language :: Python",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down