Skip to content

Pass through pipfile index urls when creating https session so that keyring fully works #5994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Pass through pipfile index urls when creating https session so that keyring fully works #5994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a0b482
pass through pipfile index urls when creating https session so that k…
mungojam Oct 24, 2023
2b1ebd0
Fix trailing whitespace
mungojam Oct 31, 2023
9fb2cfa
black formatting
mungojam Oct 31, 2023
023b6bc
Add news entry
mungojam Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/5994.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Pass through pipfile index urls when creating https session so that keyring fully works
1 change: 1 addition & 0 deletions pipenv/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ def get_requests_session_for_source(self, source):
self.s.PIPENV_MAX_RETRIES,
source.get("verify_ssl", True),
cache_dir=self.s.PIPENV_CACHE_DIR,
source=source.get("url"),
)
self.sessions[source["name"]] = session
return session
Expand Down
9 changes: 7 additions & 2 deletions pipenv/utils/internet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,15 @@
from pipenv.patched.pip._vendor.urllib3 import util as urllib3_util


def get_requests_session(max_retries=1, verify_ssl=True, cache_dir=USER_CACHE_DIR):
def get_requests_session(
max_retries=1, verify_ssl=True, cache_dir=USER_CACHE_DIR, source=None
):
"""Load requests lazily."""
pip_client_cert = os.environ.get("PIP_CLIENT_CERT")
requests_session = PipSession(cache=cache_dir, retries=max_retries)
index_urls = [source] if source else None
requests_session = PipSession(
cache=cache_dir, retries=max_retries, index_urls=index_urls
)
if pip_client_cert:
requests_session.cert = pip_client_cert
if verify_ssl is False:
Expand Down