Skip to content

Conversation

birdhackor
Copy link
Contributor

@birdhackor birdhackor commented Aug 28, 2023

Thank you for contributing to Pipenv!

The issue

When I was using pipelinev in an environment with network issues, I needed to increase the timeout setting for the connection to complete properly, but I found that the default behavior was set to 10 seconds and could not be changed, so I increased it.

The fix

Add a new ENV config for timeout, so that user can change it.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@birdhackor birdhackor requested a review from matteius August 29, 2023 01:56
@birdhackor
Copy link
Contributor Author

Fix Unexpected token ) and remove extra space.

@matteius
Copy link
Member

@birdhackor Please also update corresponding documentation for this new env var.

@birdhackor
Copy link
Contributor Author

@birdhackor Please also update corresponding documentation for this new env var.

Seems docs/configuration.md use autoclass to generate documentation. I think it will automaticly use docstrings as documentation.

Am I missing anything that needs to be modified?

@matteius
Copy link
Member

matteius commented Sep 1, 2023

@birdhackor Just a new fragment then, and there is a conflict to resolve -- also there is a second spot now in that method where there is a conflict where you'll want to pass the configured var instead of 10.

@birdhackor
Copy link
Contributor Author

@matteius I create a new PR #5907 (Re-send due to force push).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants