ruff rules SIM #5873
Merged
ruff rules SIM #5873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
approved these changes
Aug 27, 2023
|
@cclauss I think things are in a much more stable state now from my recent refactor, but I did introduce a conflict fixing things with this PR. If that can be resolved I think this can be merged. |
cclauss
force-pushed
the
ruff-rules-SIM
branch
from
647e874 to
22223f0
Compare
cclauss
commented
Aug 30, 2023
| p = os.path.join(c, "Pipfile") | ||
| if os.path.isfile(p): | ||
| return p | ||
| if i < max_depth and "Pipfile": |
There was a problem hiding this comment.
This one bugs me in both the current code and in this PR... if "Pipfile": is ALWAYS True.
There was a problem hiding this comment.
We should reduce stuff like that -- I've been trying to when I come across it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
Some code simplifications made by
ruff --select=SIM --fix .The issue
What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.
Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.
If your pull request makes a non-insignificant change to Pipenv, such as the user interface or intended functionality, please file a PEEP.
The fix
How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.