Skip to content

Conversation

matteius
Copy link
Member

@matteius matteius commented Aug 22, 2023

Handle edge case where it is expected ssh:// urls to have at least one @ symbol

The issue

Fixes Issue #5849

The fix

I think ssh:// urls require at least one @ and so checking for 2 or more in this case should be sufficient.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius marked this pull request as ready for review August 22, 2023 10:04
@matteius matteius requested a review from oz123 August 22, 2023 10:12
@matteius matteius merged commit 31c98f3 into main Aug 22, 2023
@matteius matteius deleted the issue-5849 branch August 22, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants