Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include @ when no ref is specified #5845

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Do not include @ when no ref is specified #5845

merged 5 commits into from
Aug 22, 2023

Conversation

matteius
Copy link
Member

@matteius matteius commented Aug 21, 2023

Solves some edge cases:

  • vcs sub-requirement has no ref
  • old Pipfile or Pipfile.lock that contains a ref in the vcs url.

The issue

Fixes #5843
Fixes #5846

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 August 22, 2023 01:07
@matteius matteius marked this pull request as ready for review August 22, 2023 01:27
@matteius matteius merged commit 48bf4bb into main Aug 22, 2023
11 of 19 checks passed
@matteius matteius deleted the issue-5843 branch August 22, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant