Skip to content

Cleanup secho #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 23, 2023
Merged

Cleanup secho #5804

merged 7 commits into from
Jul 23, 2023

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Jul 21, 2023 •
edited
Loading

Working on reusing rich from pipenv, so we can reuse vendored libs from it.

@oz123 oz123 requested a review from matteius July 21, 2023 19:01
@oz123 oz123 changed the title Cleanup secho DRAFT: Cleanup secho Jul 21, 2023
@oz123 oz123 force-pushed the cleanup-secho branch 3 times, most recently from b67e1dd to 07c5a5f Compare July 21, 2023 19:17
@matteius
Copy link
Member

Does rich already handle the NO_COLOR env var?

@oz123
Copy link
Contributor Author

oz123 commented Jul 22, 2023

Yes. It does:

https://rich.readthedocs.io/en/stable/console.html?highlight=NO_COLOR#environment-variables

@oz123 oz123 changed the title DRAFT: Cleanup secho Cleanup secho Jul 22, 2023
matteius
matteius reviewed Jul 22, 2023
View reviewed changes
matteius
matteius reviewed Jul 22, 2023
View reviewed changes
@oz123 oz123 merged commit 63ddce2 into main Jul 23, 2023
@oz123 oz123 deleted the cleanup-secho branch July 23, 2023 04:59
@aidencullo aidencullo mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matteius matteius matteius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oz123 @matteius