utils.toml: Handle tomlkit OutOfOrderTableProxy #5797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get this when we have subtables that do not directly follow their parent table. Fixes: pypa#5794 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
flichtenheld
force-pushed
the
tomlkit-oootp
branch
from
b6df9a4 to
24b8d08
Compare
|
Thanks for your contribution @flichtenheld ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get this when we have subtables that do not
directly follow their parent table.
Fixes: #5794
The fix
I think this issue and the fix show that we're way too deep into the tomlkit internals. I think
in the long run it would be much better to try to use a higher level interface... But I really don't
have time to go that deep into the code to find out whether that is even feasible. So for now
the minimal fix.
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.