Skip to content

Conversation

matteius
Copy link
Member

@matteius matteius commented May 18, 2023

The issue

Windows was having issues creating new virtualenvs after this patch: #5686

There were two types of issues:

  • sometimes the windows PATH may come from an env var in gitbash shell as \ instead of /
  • It was sometimes double appending the drive and creating a new directory structure for the virtualenv home.

The fix

Fix PATH edge case in pythonfinder==2.0.2

Declining on a news fragment since the issue was never published in a pipenv release.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 May 19, 2023 14:04
@matteius matteius changed the title Handle windows paths even better and utilize this utility for creating the virtualenv path. Handle windows paths better and utilize this utility for creating the virtualenv path. May 19, 2023
@matteius matteius merged commit b896dae into main May 19, 2023
@matteius matteius deleted the pythonfinder-edgecase branch May 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant