Skip to content

Conversation

wenottingham
Copy link
Contributor

@wenottingham wenottingham commented Feb 24, 2023

This shouldn't affect anything other than the shipped Pipfile.lock having one less package in it, and future-proofing in case the BeautifulSoup maintainer ever stops maintaining the redirect.

The issue

The bs4 on PyPI is just a redirect to the latest release of beautifulsoup4. Might as well point to the actual package.
Notably, in some cases, a scanner of a package downstream of pipenv will note that their dependency chain is including a package (bs4) that is marked "inactive" on PyPI.

The fix

Swap bs4 for beautifulsoup4 in the two places where it's mentioned.

Surgically remove bs4 from the Pipfile.lock.

The checklist

  • [:x:] Associated issue
  • [:heavy_check_mark:] A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@oz123
Copy link
Contributor

oz123 commented Feb 24, 2023

@wenottingham thank you for your contribution! Please fix the lint issue before we can merge this.

@wenottingham
Copy link
Contributor Author

@wenottingham thank you for your contribution! Please fix the lint issue before we can merge this.

Oops, sorry - should be fixed now.

@oz123 oz123 merged commit 424f7ea into pypa:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants