Require the actual 'beautifulsoup4' package, not the 'bs4' redirect. #5620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't affect anything other than the shipped Pipfile.lock having one less package in it, and future-proofing in case the BeautifulSoup maintainer ever stops maintaining the redirect.
The issue
The
bs4
on PyPI is just a redirect to the latest release ofbeautifulsoup4
. Might as well point to the actual package.Notably, in some cases, a scanner of a package downstream of pipenv will note that their dependency chain is including a package (
bs4
) that is marked "inactive" on PyPI.The fix
Swap
bs4
forbeautifulsoup4
in the two places where it's mentioned.Surgically remove bs4 from the Pipfile.lock.
The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.