Improve pipenv update and add pipenv upgrade command #5617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…items not being written to the Pipfile.
|
Example -- my project Now if I reset that, and say I just want to upgrade |
This was referenced Feb 20, 2023
Closed
matteius
changed the title
matteius
changed the title
|
This looks great. The way we currently use We then regularly use We have some internal packages which we often want to update without updating anything else, to do that we use the following commands: If I understand correctly, with this change we can replace these commands with |
piraartur
approved these changes
Feb 20, 2023
piraartur
suggested changes
Feb 20, 2023
There was a problem hiding this comment.
As mentioned by @kurtmckee as he has spotted changes to pipenv/cli/options.py in lines 187 and 188, I also suggested additional changes to 160 and 161, as in #5618 it was mentioned but overseen to change
|
@matteius can you please fix the conflicts? |
|
My plan for the documentation is we have a news fragment in this PR, and I've begun working on some larger effort to revamp the documentation, the first iteration which breaks apart the basics section and includes some more details on this work is here: #5621 |
piraartur
approved these changes
Mar 1, 2023
piraartur
approved these changes
Mar 1, 2023
oz123
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, there was not a reasonable way to generate a lockfile for a subset of dependencies, which is important for users in monolith systems.
The issue
Fixes #5613
Need to be able to eliminate
--keep-outdatedand provide an option that is rational for upgrading only packages and their dependencies. This should also allow elimination of--selective-upgrade, both of which are largely broken for different reasons.This also fixes a bug when adding packages to categories in the
project.pyas a side-effect of these changes.Adding an
upgradecommand will be useful for dependabot, which will want to adjust lockfiles and/or Pipfiles without invoking an install phase.The fix
This command is minimalist, it will adjust the
PipfileandPipfile.lockbut it will not install the dependencies. This will be useful for helping depandabot support newer versions of pipenv as well.Additionally, review the
pipenv updatecommand and use the same logic forpipenv update packageAthatpipenv upgradeuses, with the benefit being that it will install the dependency updates at the end. This will be useful for users that want to run fewer commands, and I believe addresses some issue reports with thepipenv updatecommand.Users can still invoke a complete re-lock based on the
Pipfilespecifiers by runningpipenv lock.The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.