Fix duplicate egg name when adding extras for package install from url #5555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requirements with a wheel path with extras caused a constraint line with
egg name which was included twice.
For example:
```
'spacy = {file = "https://files.pythonhosted.org/packages/.../spacy-3.4.3-cp39-..._x86_64.whl", extras = ["transformers"]}'
```
Produced a constraint line like the following:
```
https://files.pythonhosted.org/.../spacy-3.4.3-..._x86_64.whl#egg=spacy#egg=spacy[transformers]
```
This line triggered an unhandled excpetion `pipenv.exceptions.ResolutionFailure`,
as in #5536.
The should be submitted actually to requirementslib. However, I am
publishing it here so others can confirm it too.
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Fix #5536. Bump vendored requirementslib to 2.2.3 which includes the actual fix. Also, add a test case for this in pipenv.
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
oz123
changed the title
matteius
approved these changes
Dec 30, 2022
|
Hi @oz123 , is there a planned release for this? |
|
Probably in the end of the month. We're both busy with work stuff. Sorry. |
|
Oh please, no worries. Thank you for maintaining this great tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5536.