[fix] update --outdated raises NonExistentKey with dev package
#5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimpeko
force-pushed
the
fix-update-outdate-dev-package
branch
from
1f41495
to
4fa140d
Compare
|
@shimpeko to fix the news fragment add double backticks around |
oz123
requested changes
Dec 16, 2022
|
Thank you for your contribution! Please check the review. |
closes pypa#5540 pipenv update --outdated fail with NonExistentKey error when there are outdated packages in dev-packages category.
shimpeko
force-pushed
the
fix-update-outdate-dev-package
branch
from
9a7ddeb
to
946040f
Compare
|
@oz123 thank you fore review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5540
The issue
#5540
The fix
Lookup the target package from the correct category instead of always using
[package]category.The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.