Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 16, 2022

Thank you for contributing to Pipenv!

The issue

What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.

PEP621 encourages the Python community to migrate away from complex setup.cfg + setup.py files by putting config data in pyproject.toml. Let's keep moving in that direction. https://github.com/abravalheri/ini2toml

Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.

If your pull request makes a non-insignificant change to Pipenv, such as the user interface or intended functionality, please file a PEEP.

https://github.com/pypa/pipenv/blob/master/peeps/PEEP-000.md

The fix

How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 September 17, 2022 01:02
@oz123 oz123 merged commit b434039 into pypa:main Sep 17, 2022
@cclauss cclauss deleted the move-more-config-to-pyproject.toml branch September 17, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants