Fixes bug 4305, which no prompts to installs a pyenv python version that doesn't exist #4306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Fixes bug #4305 introduced in c23e57b which no longer identifies if the tty session is interactive. Which prevents pipenv from using pyenv to install a version of python that doesn't exist in pyenv
When this commit migrated to use vistir._isatty it bypassed
os.isatty
which supportsfileno
whilevistir._isatty
does not. Also sincevistir._isatty
swallows all exceptions we no longer need to catchUnsupportedOperation
The fix
Instead of passing in the
sys.stdout.fileno()
tovistir._isatty
pass in the streamThe checklist
news/
directory to describe this fix with the extension.bugfix
,.feature
,.behavior
,.doc
..vendor
. or.trivial
(this will appear in the release changelog).