Update vendor libraries #4302
Merged
Update vendor libraries #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techalchemy
requested changes
Jun 1, 2020
| @@ -1,21 +0,0 @@ | |||
| MIT License | |||
| @@ -422,7 +422,7 @@ def expand_paths(path, only_python=True): | |||
| isinstance(path, Sequence) | |||
| and not getattr(path.__class__, "__name__", "") == "PathEntry" | |||
| ): | |||
| for p in unnest(path): | |||
| for p in path: | |||
There was a problem hiding this comment.
Was this from the last release? I think I forgot to update pythonfinder!
| ): | ||
| yield dir_entry | ||
| dirs_to_search = [path] | ||
| while dirs_to_search: |
There was a problem hiding this comment.
glad to get this merged, so much nesting though!
| attrs==19.3.0 | ||
| distlib==0.3.0 | ||
| packaging==20.3 | ||
| pyparsing==2.4.7 | ||
| git+https://github.com/sarugaku/plette.git@master#egg=plette |
There was a problem hiding this comment.
Is the release in sync with master now? that's nice to know anyhow
| @@ -0,0 +1,78 @@ | |||
| diff --git a/pipenv/vendor/pythonfinder/compat.py b/pipenv/vendor/pythonfinder/compat.py | |||
There was a problem hiding this comment.
sorry again for the patches. For most of these they really should be caught by the vendoring import rewrites but for some reason they arent
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
techalchemy
approved these changes
Jun 1, 2020
This was referenced Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
The fix
requirements1.5.9->1.5.10pythonfinder1.2.2->1.2.4The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.