asdf-support #3888
Closed
asdf-support #3888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Specifying Versions section of the Basics documentation, there is a misleading code comment saying that requests~=1.2 is equivalent to requests~=1.2.0, which it isn’t. ~=1.2 is equivalent to >=1.2,<2.0, but ~=1.2.0 is equivalent to >=1.2.0,<1.3. Fixed by removing the comment.
Added a pull request description file to the news folder. Marked as trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
#3875 adds support for asdf, much like the pyenv integration.
The fix
The
asdfandpyenvinterfaces are much the same. So I just subclassed thepyenvrunner. There may be room to more generally handle these kind of integrations, but I didn't want to make too dramatic of a change to the code base.Open to any better solutions.
I've been able to test it locally. However, the current pipenv.core.find_system_python on master seems to be misbehaving. I assume this is getting some changes and known about. If not I can open an issue with what I'm seeing (wrong python version returned
3.7.4when I ask for--python 3.6.0).The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.