Revert "In HackedPythonVersion, patch sys.version_info" #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vphilippon
requested changes
Nov 17, 2017
There was a problem hiding this comment.
The content of the "A dot and an if away from salvation" commit should be kept though. those were things that still needed to be fixed.
So, only revert 73ba65f
|
|
||
| # Second (last-resort) attempt: | ||
| if resolved_tree is None: | ||
| with HackedPythonVersion(python_version='.'.join([str(s) for s in sys.version_info[:3]]), python_path=backup_python_path): |
There was a problem hiding this comment.
We should keep the '.' and indentation fixes though
There was a problem hiding this comment.
That's fine, let's get a PR up that pulls out what we need to remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts kennethreitz/pipenv#1076