Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI requirements dump - broken import and fully qualified function calls #4286

Closed
techalchemy opened this issue May 29, 2020 · 0 comments · Fixed by #4287
Closed

CLI requirements dump - broken import and fully qualified function calls #4286

techalchemy opened this issue May 29, 2020 · 0 comments · Fixed by #4287
Labels
Category: CLI Issue relates to the CLI Priority: High This item is high priority and should be resolved quickly. Type: Bug 🐛 This issue is a bug.
Milestone
2020.6.x bugfix r...

Comments

@techalchemy
Copy link
Member

Updates made to cli.command have added a call to exceptions.PipenvOptionsError -- but exceptions is not imported. Additionally, a few click.echo calls made it through, but click isn't imported as a fully qualified module.
@techalchemy techalchemy added Type: Bug 🐛 This issue is a bug. Priority: High This item is high priority and should be resolved quickly. Category: CLI Issue relates to the CLI labels May 29, 2020
techalchemy added a commit that referenced this issue May 29, 2020
@techalchemy
Add missing import and fix function calls in cli
95e83a3 
- Add missing `PipenvOptionsError` import to `pipenv.cli.command`
- Fix calls to `click.echo` (should be just `echo`)
- Fixes #4286

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
@techalchemy techalchemy mentioned this issue May 29, 2020
Merged
@frostming frostming added this to the 2020.6.x bugfix release milestone Jun 1, 2020
@dependabot dependabot bot mentioned this issue Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: CLI Issue relates to the CLI Priority: High This item is high priority and should be resolved quickly. Type: Bug 🐛 This issue is a bug.
Projects
None yet
Milestone
2020.6.x bugfix release
Development

Successfully merging a pull request may close this issue.

Add missing import and fix function calls in cli pypa/pipenv
2 participants
@techalchemy @frostming