Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --system to pipenv sync #2227

Closed
matthijskooijman opened this issue May 20, 2018 · 8 comments · Fixed by #4441
Closed

Support --system to pipenv sync #2227

matthijskooijman opened this issue May 20, 2018 · 8 comments · Fixed by #4441
Labels
good first issue Issues suitable as a newcomer to get familiar with Pipenv! help wanted Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@matthijskooijman
Copy link

I'm trying to install dependencies inside of tox, which I believe needs --system (to install into tox's virtualenv instead of into pipenvs own virtualenv). See also #154.

However, pipenv sync, which is the new way to install dependencies from Pipfile.lock does not support --system (it seems it was intentionally left out initially in #1463), so I have to resort to pipenv install.

It seems it would be useful to support --system for sync as well.

frostming added a commit to frostming/pipenv that referenced this issue May 21, 2018
@kennethreitz
Copy link
Contributor

+1

@matthijskooijman
Copy link
Author

I just tried aca8e12 from @frostming's branch, and it works as expected in my usecase (see https://travis-ci.org/evolution-events/Artaxerxes/jobs/382857314). Thanks!

@techalchemy techalchemy added Type: Enhancement 💡 This is a feature or enhancement request. help wanted good first issue Issues suitable as a newcomer to get familiar with Pipenv! labels Jun 26, 2018
@txomon
Copy link

txomon commented Jul 16, 2018

Hey, just in case pipenv uses Tox's virtualenv directly, with no intervention needed. ( for example https://circleci.com/gh/txomon/mosbot/17)

@nre-ableton
Copy link

I really would appreciate having pipenv sync --system as well. This would be the preferred way to use pipenv in a Docker container. At the moment I'm using pipenv install --system --deploy which is not as great of a solution.

It seems that this issue has stalled. Would it make sense to take
aca8e12 and make a PR from it?

@techalchemy techalchemy added this to the March Release milestone Mar 6, 2019
@jonbesga
Copy link

jonbesga commented Apr 13, 2019

Is there any difference between pipenv install --ignore-pipfile and pipenv sync?

I'm currently using pipenv install --system --ignore-pipfile when I want to install dependencies from the Pipfile.lock into the system.

Update: Found an explanation in #3150, it seems that using the pipenv install --system --ignore-pipfile --deploy should be equivalent to pipenv sync

@BenjamenMeyer
Copy link

I've managed to get pipenv sync and pipenv install --system --ignore-pipfile --deploy to mostly function under tox, but if I'm running directly through tox then something always fails to install and it never recovers. If I go into the virtualenv then everything installs just fine.

@shunkakinoki
Copy link

+1

@mortezaPRK
Copy link

there is a workaround which I'm using in my deployments.

in CI, I will check if Pipfile.lock and Pipfile are in sync in a CI pipeline during tests:

pipenv install --deploy

then, during creation of Docker images, I don't include Pipfile and use pipenv install --ignore-pipfile --deploy --system.

rm Pipefile
touch Pipefile
pipenv install --ignore-pipfile --deploy --system

It is the fastest method I found.

@brainwane brainwane removed this from the March 2020 Release milestone Mar 24, 2020
Riku-1 added a commit to Riku-1/django-blog-sample-docker that referenced this issue Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues suitable as a newcomer to get familiar with Pipenv! help wanted Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants