Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 20.3.4 #9494

Closed
wants to merge 16 commits into from
Closed

Release 20.3.4 #9494

wants to merge 16 commits into from

Conversation

pradyunsg
Copy link
Member

This isn't going to get merged. But, hey, this is where I'm cutting 20.3.4 from and wrapping that show up.

@pypa-bot
Copy link

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@pypa-bot pypa-bot added the needs rebase or merge PR has conflicts with current master label Jan 23, 2021
@pradyunsg pradyunsg added this to the 20.3.4 milestone Jan 23, 2021
@pradyunsg
Copy link
Member Author

Alrighty! I've cut 20.3.4 off of the correct commit, and uploaded it. Closing this since making this mergable is more effort than any value it'd provide.

@pradyunsg pradyunsg closed this Jan 23, 2021
@pradyunsg pradyunsg deleted the release/20.3.4 branch January 23, 2021 13:00
@sbidoul
Copy link
Member

sbidoul commented Jan 24, 2021

@pradyunsg Thanks for the release!

It seems the fix for #9273 did not make it. Although it's a regression I suppose there are few users for that so if nobody else than me complains there is probably no need to bother doing another 20.3 release.

@pradyunsg
Copy link
Member Author

Oh. I didn't see it in the 20.3.4 milestone, so I didn't cherry-pick the commit.

@sbidoul
Copy link
Member

sbidoul commented Jan 24, 2021

@pradyunsg it was in the milestone but was closed when merged on master for 21.0.

Not sure what's the best way to track these. In my projects have the habit of creating a branch to track bugfix backports.

@pradyunsg
Copy link
Member Author

Ah. I think I see what happened: I cherry picked the PRs that were in the milestone, and, well, the corresponding PR for the issue wasn't in the 20.3.4 milestone, but in 21.0 milestone: #9274. I'd missed that you'd changed that. :(

Let's see if anyone else cares about this though -- I'd really like to not cut a 20.3.5 for just that change.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs rebase or merge PR has conflicts with current master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants