-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 20.3.4 #9494
Release 20.3.4 #9494
Conversation
Verify built wheel contains valid metadata
…tracking Avoid downloading multiple candidates of a same version
This reverts commit ab3ee71.
This reverts commit 94882fd.
This reverts commit 8adbc21.
This reverts commit 1471897.
This reverts commit e9f738a.
Revert additional changes that were made after 7969 and depended on it.
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
Alrighty! I've cut 20.3.4 off of the correct commit, and uploaded it. Closing this since making this mergable is more effort than any value it'd provide. |
@pradyunsg Thanks for the release! It seems the fix for #9273 did not make it. Although it's a regression I suppose there are few users for that so if nobody else than me complains there is probably no need to bother doing another 20.3 release. |
Oh. I didn't see it in the 20.3.4 milestone, so I didn't cherry-pick the commit. |
@pradyunsg it was in the milestone but was closed when merged on master for 21.0. Not sure what's the best way to track these. In my projects have the habit of creating a branch to track bugfix backports. |
Ah. I think I see what happened: I cherry picked the PRs that were in the milestone, and, well, the corresponding PR for the issue wasn't in the 20.3.4 milestone, but in 21.0 milestone: #9274. I'd missed that you'd changed that. :( Let's see if anyone else cares about this though -- I'd really like to not cut a 20.3.5 for just that change. |
This isn't going to get merged. But, hey, this is where I'm cutting 20.3.4 from and wrapping that show up.