Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation deadline for #8368 #9423

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jan 3, 2021

There is no urgency to remove this, and if we ever remove it, it might be better to coordinate it with the other legs of #8102.

That said, so far I've not noticed good reasons to keep it in the feedback we got in #8368.

@sbidoul sbidoul added this to the 21.0 milestone Jan 3, 2021
@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 3, 2021
@pfmoore
Copy link
Member

pfmoore commented Jan 9, 2021

A quick note. Pip 21.0 is due for release in about 2 weeks (see #9282). This item is on the 21.0 milestone, so it either needs to be implemented and merged to master before then, or it will miss the release (and I'll move it to the 21.1 milestone).

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the right thing to do given that nobody is proposing to remove this on any version yet, let alone 21.0

@sbidoul sbidoul merged commit 5629e09 into pypa:master Jan 9, 2021
@sbidoul sbidoul deleted the 8368-no-deadline branch January 9, 2021 12:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants