Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeze: make --all the default & deprecate it #9068

Closed
wants to merge 1 commit into from
Closed

freeze: make --all the default & deprecate it #9068

wants to merge 1 commit into from

Conversation

xavfernandez
Copy link
Member

Close #4256

And small step towards #7157

pradyunsg
pradyunsg reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want a transitory step, where we present a warning before making such a change, as per our https://pip.pypa.io/en/stable/development/release-process/#deprecation-policy?

@xavfernandez
Copy link
Member Author

I hesitated and I agree that this PR doesn't follow our deprecation policy.

But following it would mean to:

  • print a deprecation warning when freezing without --all since the behaviour will change
  • print a deprecation warning when freezing with --all since the option is going away

which would be bothersome for users who will want an option to disable the warning.

I guess a --use-feature=freeze-all could help with the transition ?

pfmoore
pfmoore approved these changes Oct 30, 2020
View reviewed changes
tests/functional/test_freeze.py Outdated Show resolved Hide resolved
@xavfernandez
Copy link
Member Author

An alternative plan could be #4256 (comment)

@pradyunsg pradyunsg mentioned this pull request Oct 30, 2020
Closed
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 4, 2021
@pradyunsg
Copy link
Member

@xavfernandez Nudge to update this.

@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 6, 2021
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Aug 15, 2021
pradyunsg
pradyunsg reviewed Sep 18, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavfernandez Could you update this PR?

src/pip/_internal/commands/freeze.py
deprecated(
"--all is now the default behavior and does nothing",
None,
gone_in="23.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gone_in="23.3",
gone_in="23.0",

Let's keep this for as little time as possible?

@pradyunsg
Copy link
Member

Closing this out given the lack of activity.

@pradyunsg pradyunsg closed this May 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
needs rebase or merge PR has conflicts with current master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit displaying setuptools in pip freeze?
5 participants
@xavfernandez @BrownTruck @pradyunsg @pfmoore @pypa-bot