Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a testing case for a future check integrity flag #8633

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add a testing case for a future check integrity flag #8633

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c751bca
Add a failing test case for a future check flag
fbidu Jul 26, 2020
ae8bcac
Update tests/functional/test_check.py docstring
fbidu Jul 26, 2020
f4cf16d
Mark tests/functional/test_check.py as expected fail
fbidu Jul 26, 2020
8227dcd
Update tests/functional/test_check.py
fbidu Jul 26, 2020
d0d6d91
Update tests/functional/test_check.py
fbidu Jul 26, 2020
b3327e8
Fix test_check pytest import
fbidu Aug 10, 2020
ce61044
Gitignore wheel metadata
fbidu Aug 10, 2020
9a00373
Add trivial NEWS entry
fbidu Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests/functional/test_check.py docstring 
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
  • Loading branch information
@fbidu @webknjaz
fbidu and webknjaz authored Jul 26, 2020
commit ae8bcacf5f3d54119c15356ff685db13aeb2fcdf
4 changes: 1 addition & 3 deletions tests/functional/test_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,9 +295,7 @@ def test_check_include_work_dir_pkg(script):


def test_check_integrity_errors_on_missing_files(data, script, tmpdir):
fbidu marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, this is a negative test. It's probably reasonable to add a positive test too (for when the integrity is fine)

"""
Work-in-progress failing test for a flag that detects broken packages
"""
"""Ensure that pip check detects a missing file post-install."""
to_install = data.packages.joinpath("pip-test-package-0.1.tar.gz")
result = script.pip_install_local(to_install)
assert 'Successfully installed pip-test-package' in result.stdout
Expand Down