-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor operations.prepare.prepare_linked_requirement #8411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just talked with @McSinyx on a different communication channel.
This PR contains 2 changes currently -- the behavior change mentioned in the title and a refactoring change to address a "TODO: break this up" comment. He'll be breaking this PR into smaller PRs, for each of the separate changes.
0da0591
to
152a04b
Compare
152a04b
to
a1159d7
Compare
@McSinyx to facilitate (and speed-up) review do not hesitate to split your PR in small commits, each one doing a small thing (such as factoring out a function, reformatting code, etc). |
2bfa03f
to
02c2815
Compare
@pradyunsg, @sbidoul, I've just split the patch into multiple commits and hopefully it's nicer for review now. |
02c2815
to
90615fe
Compare
90615fe
to
93ad5d2
Compare
93ad5d2
to
8064e62
Compare
Oh no I messed up rebasing stuff 😄 |
8064e62
to
110d374
Compare
110d374
to
8b5ff72
Compare
I'd appreciate another pair of 👀 on this PR. ^>^ |
@sbidoul, I am sorry to ask for this on Sunday, but may I have your review on this PR? |
I'll go ahead and merge this, since this looks good to me. :) |
Break
operations.prepare.prepare_linked_requirement
into smaller (not small enough IMHO) methods.
This not meant to solve GH-7815 completely. I agree with #7815 (comment) that we should somehow put the
populate_link
in the same place for the logic to be easier to parse.Rather, this is purely to make the method easier for me to read to proceed with more experiments on the downloading process.
As for the stylistic changes with the placement of the closing parentheses, I don't really have a strong opinion on them; although I'd be happier if they're not used for single-line argument list.