-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add flake8-bugbear plugin to pre-commit and fix "tests" accordingly #8398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3048b4b
to
59b27ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
59b27ad
to
b542e21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configurations look good to me. Any recommendation if I want to run flake8
manually on the code base? Is it enough to simply install flake8-bugbear
? I want to set up some editor integrations without using pre-commit for performance reasons.
Thanks for the approval. Yep, after installing Also if you are running More details can be found in the docs at https://flake8.pycqa.org/en/latest/user/configuration.html#configuring-flake8 If I missed something here, @asottile can chime in as well with his suggestions. |
b542e21
to
e8535da
Compare
I think this is good to go and can be merged. I will create the next PR to add |
e8535da
to
7744bd2
Compare
7744bd2
to
06654ef
Compare
Thanks! |
Thanks for the merge :) The follow PR has been filed, please have a look |
Towards #5537
This adds flake8-bugbear plugin to pre-commit, and fixes the relevant errors just in the
tests
folder.If the direction of this PR looks good, a follow up PR will remove warnings from
src/pip/_internal
folder forflake8-bugbear