Skip to content

Canonicalise package name in tests.lib.create_basic_wheel_for_package #8067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020
Merged

Canonicalise package name in tests.lib.create_basic_wheel_for_package #8067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bcccbd
Canonicalise package name in tests.lib.create_basic_wheel_for_package
deveshks Apr 16, 2020
22878a8
Added unit tests to verify correct normalization of package name
deveshks Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added news/FCD7E4ED-BA3E-4018-B43E-D445DA8E542B.trivial
View file
Open in desktop
Empty file.
13 changes: 13 additions & 0 deletions tests/functional/test_install_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,3 +587,16 @@ def test_wheel_install_fails_with_badly_encoded_metadata(script):
assert "Error decoding metadata for" in result.stderr
assert "simple-0.1.0-py2.py3-none-any.whl" in result.stderr
assert "METADATA" in result.stderr


@pytest.mark.parametrize(
'package_name',
['simple-package', 'simple_package'],
)
def test_correct_package_name_while_creating_wheel_bug(script, package_name):
"""Check that the package name is correctly named while creating
a .whl file with a given format
"""
package = create_basic_wheel_for_package(script, package_name, '1.0')
wheel_name = os.path.basename(package)
assert wheel_name == 'simple_package-1.0-py2.py3-none-any.whl'
3 changes: 3 additions & 0 deletions tests/lib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,6 +994,9 @@ def create_basic_wheel_for_package(
if extra_files is None:
extra_files = {}

# Fix wheel distribution name by replacing runs of non-alphanumeric
# characters with an underscore _ as per PEP 491
name = re.sub(r"[^\w\d.]+", "_", name, re.UNICODE)
archive_name = "{}-{}-py2.py3-none-any.whl".format(name, version)
archive_path = script.scratch_path / archive_name

Expand Down