-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support including port part in trusted-host #6909
Conversation
e8bdf62
to
bfda480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple comments. Also, the command-line help should be updated to reflect the change.
ef3ad9a
to
dbf4120
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Looking a lot better! Some more comments.
c5dc2e4
to
7f184ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes. One more comment that I can see. Almost there!
Oh, and there is still the comment from before re: updating the command-line help to say that host-port pair is also acceptable. That code is in |
7f73b74
to
72cb4db
Compare
@frostming By the way, regarding the comment quoted above, would you mind filing that as a separate issue so we don't lose track of it? It would be much appreciated.. |
FYI, I made some minor formatting tweaks in preparation for merging. |
Thanks again, @frostming! 🎉 |
@cjerdonek Thanks for that, I created #6931 to track the remaining issue. |
Closes #6886
Closes #6710
This PR proposes official support for including port part in trusted-host option, for both HTTP and HTTPS indexes. So:
--trusted-host example.com
trusts all these indexes:http://example.com
http://example.com:8080
https://example.com
https://example.com:8080
While
--trusted-host example.com:8080
only trusts the indexes with port 8080 exactly:http://example.com:8080
https://example.com:8080