Add SearchScope class for --find-links and --index-url related options #6624
+201
−114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of two PR's to add a
SearchScope
class to encapsulate the--find-links
and--index-url
-related options.The current PR adds the class and stores
search_scope
onPackageFinder
instead offind_links
andindex_urls
. The second PR will changePackageFinder.create()
to accept aSearchScope
object instead offind_links
andindex_urls
.This change has a number of benefits, including--
PackageFinder()
andPackageFinder.create()
,PackageFinder
class andindex.py
by extracting more code from it, and--find-links
and--index-url
options, which makes things easier to test and will give us more flexibility in handling those options.