-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Tighten up the test suite's stderr checks #6351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
67fb4fe
to
a5c6662
Compare
@xavfernandez This is now ready to be reviewed. There are two things I think should be done in a follow-on PR:
Both of the above would make the tests more precise. I tried doing (1) here, but I found that there are ~35-70 tests (depending on how much group 1 and 2 overlap) where I don't know how many tests (2) would affect. |
d8058a3
to
e175817
Compare
tests/conftest.py
Outdated
@@ -303,6 +303,9 @@ def script(tmpdir, virtualenv, deprecated_python): | |||
assert_no_temp=True, | |||
|
|||
# Deprecated python versions produce an extra deprecation warning | |||
# This also addresses a possible warning on old versions of Python | |||
# (< 2.7.9) about the lack of an SSLContext in urllib3/requests, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't clear: one could think that 2.7.9 is dealt with in deprecated_python
but currently, only 2.7 and 3.4 are.
(and if the 2.7 warning is removed, it's unlikely someone will add a special case for 2.7.9...)
I think we can drop the comment about 2.7.9 altogether.
e175817
to
66ae681
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is a relatively simple PR that does the following four things (each in a separate commit):
allow_stderr_warning=True
instead ofexpect_stderr=True
. This narrows / tightens up the test expectation.SSLContext
warning, since that is now subsumed by the deprecated Python check.expect_stderr=True
mean the weakerallow_stderr_warning=True
. Similar to (1), this makes the test expectation more specific.