Fix utils.encoding.auto_decode() LookupError with invalid encodings #6311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
approved these changes
Mar 1, 2019
|
amended |
cjerdonek
reviewed
Mar 1, 2019
utils.encoding.auto_decode() was broken when decoding Big Endian BOM byte-strings on Little Endian or vice versa. The TestEncoding.test_auto_decode_utf_16_le test was failing on Big Endian systems, such as Fedora's s390x builders. A similar test, but with BE BOM test_auto_decode_utf_16_be was added in order to reproduce this on a Little Endian system (which is much easier to come by). A regression test was added to check that all listed encodings in utils.encoding.BOMS are valid. Fixes pypa#6054
|
amended |
cjerdonek
approved these changes
Mar 1, 2019
|
Thanks, @hroncok! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.encoding.auto_decode()was broken when decoding Big Endian BOM byte-strings on Little Endian or vice versa.The
TestEncoding.test_auto_decode_utf16_letest was failing on Big Endian systems, such as Fedora's s390x builders. A similar test, but with BE BOMtest_auto_decode_utf16_bewas added in order to reproduce this on a Little Endian system (which is much easier to come by).A regression test was added to check that all listed encodings in
utils.encoding.BOMSare valid.Fixes #6054