Simplify FrozenRequirement._init_args_from_dist() #5837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
type: refactor
|
PS - this is the last refactoring change prior to submitting a PR to address issue #5031. |
pradyunsg
approved these changes
Oct 8, 2018
cjerdonek
force-pushed
the
simplify-init-args-from-dist
branch
from
bcc3297
to
b3ac98e
Compare
|
Rebased with the 19.0 / deprecation tweak. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies
FrozenRequirement. _init_args_from_dist()by using guard clauses when it makes sense, and eliminating temporary variables that aren't needed. This lets us significantly reduce the amount of indentation and if-else branching.The PR is broken up into a number of commits, each one making a single, simple refactoring change.