Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcs.git: make sure to always be in detached HEAD #3749

Closed
wants to merge 1 commit into from
Closed

vcs.git: make sure to always be in detached HEAD #3749

wants to merge 1 commit into from

Conversation

BrownTruck
Copy link
Contributor

closes issue #2037

This was automatically migrated from #2340 to reparent it to the master branch. Please see original pull request for any previous discussion.

Original Submitter: @xavfernandez

@BrownTruck BrownTruck mentioned this pull request May 26, 2016
Closed
@BrownTruck
Copy link
Contributor Author

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Apr 8, 2017
@pradyunsg pradyunsg added good first issue A good item for first time contributors to work on C: vcs pip's interaction with version control systems like git, svn and bzr and removed good first issue A good item for first time contributors to work on labels Aug 21, 2017
@pradyunsg pradyunsg mentioned this pull request Aug 21, 2017
Closed
@cjerdonek
Copy link
Member

cjerdonek commented Aug 21, 2017 •
edited
Loading

I really don't think this change is the way to go. If someone specifies a branch that should be installed, then the branch should be checked out rather than detached HEAD. That seems much more natural to me. It also lets you "recover" what the specifier was from the state of the repo whereas with detached HEAD you lose information.

@xavfernandez
Copy link
Member

Agreed.

@xavfernandez xavfernandez deleted the detached_git branch September 29, 2017 22:41
@cjerdonek
Copy link
Member

Thanks, @xavfernandez. I appreciate it.

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
@pradyunsg pradyunsg removed the needs rebase or merge PR has conflicts with current master label Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: vcs pip's interaction with version control systems like git, svn and bzr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrownTruck @cjerdonek @xavfernandez @pradyunsg