-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add privacy notice to documentation index #13651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/html/index.md
Outdated
|
|
||
| ## Privacy Notice | ||
|
|
||
| pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and | |
| Pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and |
|
@pfmoore sorry I overlooked your suggestion before recommitting, could you bring it up again? |
docs/html/index.md
Outdated
|
|
||
| ## Privacy Notice | ||
|
|
||
| pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and | |
| Pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and |
Repeated as requested.
I was surprised that github didn't simply carry this suggestion forward. As far as I can see, you didn't force-push or anything that would have made the original suggestion unmergeable. Weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, I see - you removed a trailing space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still hasn't been incorporated. Sentences should start with a capital letter.
Co-authored-by: Paul Moore <p.f.moore@gmail.com>
docs/html/index.md
Outdated
| pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and | ||
| user experience. No personally identifiable information is collected. For more details, see pip's [Privacy Policy](https://www. | ||
| pypa.io/privacy/). | ||
| pypa.io/privacy/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it seems strange to line break in the middle of a URL. Even if it works, can you break the line somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep sure :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
god there seems to be pre commit issues, please standby for a minute
|
Fixed, Moved the URL to a single line to avoid the line break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should've been clearer. I don't think we should be implying that the pip project is directly collecting any telemetry.1 What pip does is send over telemetry through the User-Agent HTTP header and then it's up to the remote index to store/process that if it wishes to. In other words, I'd like something along the lines of #13559 (comment).
Also, the PyPA doesn't have an official privacy policy. I'm not sure where that link came from, but it returns a 404.
Footnotes
-
Given the related issue was raised because corporate environments are sometimes put off by the linehaul service, we want to make it clear that if they use their private indices, there are zero privacy implications. ↩
docs/html/index.md
Outdated
| ## Privacy Notice | ||
|
|
||
| <<<<<<< HEAD | ||
| pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collects
Collects implies pip is storing data somewhere, it is not, it transmits some environment information to the remote index, which may or may not collect that data.
anonymized
Anonymized is usually the term used for removing or obfuscating personally identifying data, pip isn't removing or obfuscating data so I don't think it's the correct term.
(pip version, Python version, and command success/failure)
This is not a complete list, so it should either be complete or make it clear it's not complete, e.g. by adding an "etc."
I also don't think it's an accurate list, "command success/failure" is that true? How does that even work? Pip doesn't know if a command will succeed or fail until after the HTTP request.
improve reliability and user experience
Are either of these stated goals of line haul?
docs/html/index.md
Outdated
| <<<<<<< HEAD | ||
| pip collects anonymized usage data (pip version, Python version, and command success/failure) to help improve reliability and | ||
| user experience. No personally identifiable information is collected. | ||
| For more details, see pip's [Privacy Policy](https://www.pypa.io/privacy/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip's Privacy Policy.
This isn't a real thing, even if it was it wouldn't be pip's private policy it would be PyPA's.
As a side note, if you are using AI to generate the language here it is your responsibility to validate the accuracy of the language before submitting the PR.
How about something like this? The wording needs work, but the general idea is there. Unfortunately, PyPI's privacy policy does not mention the linehaul service at all. That seems like a glaring omission. |
docs/html/index.md
Outdated
|
|
||
| ## Privacy Notice | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've managed to somehow leave a merge conflict marker in the file.
That seems like much better wording. |
|
@pfmoore @ichard26
I've also removed the link, I seem to have followed an unverified link, my bad. Let me know if the wording further needs any improvements:) |
|
|
||
| ## Privacy Notice | ||
|
|
||
| The pip project does not collect any telemetry, however, pip will send |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that the phrasing "the pip project" is a little awkward here. It's the program, not the project, that we're talking about. Can't we just say "Pip does not collect any telemetry..."? If this is a circumlocution to avoid the debate over whether we capitalise "pip" at the start of a sentence, I'd rather just have that debate now (IMO, we should capitalise - "pip" is just a word like any other, it shouldn't have special capitalisation rules).
Having said this, I really don't care that much - if another maintainer wants to approve this PR as it stands, I'm fine with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I agree on this, Pip does not collect any telemetry sounds more fitting imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, here's my suggested change:
| The pip project does not collect any telemetry, however, pip will send | |
| Pip does not collect any telemetry, however, it will send |
I'll wait a while in case any other maintainers care enough to object, otherwise I'll make this change and merge.
Fixes #13559
Adds a brief privacy notice to the root documentation page (
docs/html/index.md) as suggested by @ichard26.The notice is kept short and includes:
This addresses the need for transparency regarding pip's data collection practices.